allow null response from routes

juliangut · Apr 4, 2020 · b96d660 · b96d660
1 parent c59ee40
commit b96d660
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 1 deletion.
diff --git a/src/Strategy/ResponseTypeStrategyTrait.php b/src/Strategy/ResponseTypeStrategyTrait.php
@@ -67,12 +67,16 @@ public function setResponseHandler(string $type, $responseHandler): void
     /**
      * Handle route response.
      *
-     * @param ResponseInterface|ResponseType|string $dispatchedResponse
+     * @param ResponseInterface|ResponseType|string|null $dispatchedResponse
      *
      * @return ResponseInterface
      */
     protected function handleResponse($dispatchedResponse): ResponseInterface
     {
+        if ($dispatchedResponse === null) {
+            return $this->responseFactory->createResponse();
+        }
+
         if (\is_string($dispatchedResponse)) {
             $response = $this->responseFactory->createResponse();
             $response->getBody()->write($dispatchedResponse);

diff --git a/tests/Routing/Strategy/ResponseTypeStrategyTraitTest.php b/tests/Routing/Strategy/ResponseTypeStrategyTraitTest.php
@@ -28,6 +28,36 @@
  */
 class ResponseTypeStrategyTraitTest extends TestCase
 {
+    public function testNullDispatch(): void
+    {
+        $container = $this->getMockBuilder(ContainerInterface::class)
+            ->getMock();
+        /* @var ContainerInterface $container */
+        $request = $this->getMockBuilder(ServerRequestInterface::class)
+            ->getMock();
+        /* @var ServerRequestInterface $request */
+        $response = $this->getMockBuilder(ResponseInterface::class)
+            ->getMock();
+        /* @var ResponseInterface $response */
+
+        $strategy = new ResponseTypeStrategyStub([], new ResponseFactory(), $container);
+
+        $callback = function (
+            ServerRequestInterface $receivedRequest,
+            ResponseInterface $receivedResponse
+        ) use (
+            $request,
+            $response
+        ): void {
+            static::assertSame($request, $receivedRequest);
+            static::assertSame($response, $receivedResponse);
+        };
+
+        $return = $strategy($callback, $request, $response, []);
+
+        static::assertEquals('', (string) $return->getBody());
+    }
+
     public function testStringDispatch(): void
     {
         $container = $this->getMockBuilder(ContainerInterface::class)