Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update appendPage pages arg type declaration to support page ranges #383

Merged
merged 1 commit into from
May 4, 2024
Merged

Update appendPage pages arg type declaration to support page ranges #383

merged 1 commit into from
May 4, 2024

Conversation

josiahyeow
Copy link
Contributor

According to the docs, page ranges can be provided to the appendPage method as shown the example.

e.g.

pdfDoc.appendPage(longPDF, [
    [1, 3],
    [6, 20],
  ])

The current type declaration for pages only supports pages value to be [1, 3, 4] or simply 1. This PR updates this type declaration to support the ranges shown in the example.

@josiahyeow
Copy link
Contributor Author

Fixed codestyle issues

@julianhille julianhille merged commit 9e7a007 into julianhille:develop May 4, 2024
97 of 107 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianhille julianhille julianhille approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josiahyeow @julianhille