Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure bindings get copied #391

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Aeolun
Copy link

@Aeolun Aeolun commented Jul 26, 2024

As far as I understand, this ensures that installed bindings get copied along with the package code when running pnpm deploy.

It's hard to test this due to the nature of the install. I'm copying the file manually now.

This ensures that bindings get copied along with the package code when running `pnpm deploy`.
@julianhille
Copy link
Owner

julianhille commented Jul 26, 2024

I'm afraid this is nothing i should add.
The files array makes sure these files are inside of a packaged tarball, but because of the nature of a binary, which depends on the architecture, bit size, os, cpp lib, node version this is not possible.

You have two options here:

  • you need to build very specifically with the same version, node, arch, etc locally and add that file path to be deployed to your files dir. with the full path to the nodes/muhammara... (not 100% sure how this works but with electron this was the way to go)
  • could have a deploy or install step on your hosting machine, as muhammara uses prebuilt on install which gets infos about the current system and downloads the binary from github)

@julianhille
Copy link
Owner

Can you give a minimal example with pnpm?
I like to test some edge cases.
As stated before normally its not a good idea to bundle the binary on purpose because it is coupled to the exact match of os/arch/node version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants