Skip to content

Commit

Permalink
update again
Browse files Browse the repository at this point in the history
  • Loading branch information
juliankrispel committed May 18, 2020
1 parent 281f319 commit 903bff1
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Create Release if does not exist
run: echo "release this"
if: ${{ steps.changelog_reader.outputs.already_released == false }}
if: ${{ steps.changelog_entry.outputs.not_released_yet == true }}

# - name: Create Release
# id: create_release
Expand Down
7 changes: 3 additions & 4 deletions scripts/release.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ async function run() {
core.setOutput('title', version.title)
core.setOutput('version', version.version)
core.setOutput('description', version.body)
core.setOutput('already_released', false)
core.setOutput('unreleased', true)


packages.forEach(package => {
Expand All @@ -33,11 +33,10 @@ async function run() {
}
})

// check if already released on github
// check if already released on github, if it does we set the output of unreleased to false
releases.forEach(release => {
if(release.tag_name.includes(version.version)) {
core.setFailed(`Release failed because version in changelog: ${version.version} isn't the same as version in ${packageJson.name} which is ${packageJson.version}`)
core.setOutput('already_released', true)
core.setOutput('unreleased', false)
}
})
}
Expand Down

0 comments on commit 903bff1

Please sign in to comment.