Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hook up to MOI (WIP) #56

Merged
merged 13 commits into from
Oct 1, 2018
Merged

hook up to MOI (WIP) #56

merged 13 commits into from
Oct 1, 2018

Conversation

chriscoey
Copy link
Collaborator

@chriscoey chriscoey commented Sep 7, 2018

fixes #9
requires transforming symmetric matrix inputs/outputs using scaled svec form (would be nice if MOI still supported scaled triangle)

  • contlinear tests
  • contconic tests

@chriscoey
Copy link
Collaborator Author

chriscoey commented Sep 12, 2018

this will be easier after #62 because we will have support for constraint cones

@chriscoey
Copy link
Collaborator Author

chriscoey commented Oct 1, 2018

🎉 MOI conic tests are mostly passing except for

I plan to fix the SDP test failures and then merge this, and work on #16 soon so that all the MOI tests pass

@chriscoey
Copy link
Collaborator Author

Actually SDP may be failing simply because MOI's PSD triangle is unscaled, whereas hypatia's is scaled (svec form)

@chriscoey
Copy link
Collaborator Author

excluding SDP tests until jump-dev/MathOptInterface.jl#531 is fixed

@chriscoey
Copy link
Collaborator Author

besides SDP/logdet/rootdet tests, which will be fixed by MOI bridges, only 3 test failures remain across contlinear and contconic tests, and they are only on LPs. 2 failures are due to redundancy or inconsistency of dual equalities, and 1 failure (linear15test) is due to having more equality constraints than variables (p > n).

both will be solved by #16.

@chriscoey
Copy link
Collaborator Author

restoring tolerances to 1e-4 cause a failure on rotatedsoc3, that might be solved by #65

@chriscoey chriscoey merged commit f947122 into master Oct 1, 2018
@chriscoey chriscoey deleted the mathoptint branch October 1, 2018 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

complete and test the MOI interface
1 participant