bit of cleanup of relative entropy cone #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs @chriscoey to take a look. I can't really review this competently, other than noting that the tests pass. |
|
Actually @lkapelevich is the one who knows about this particular cleanup. |
chriscoey
reviewed
Apr 11, 2024
chriscoey
reviewed
Apr 11, 2024
|
Thanks @araujoms! In general we put lots of effort into optimizing the oracle code for most of the cones, but not so much for epitrrelentropytri, because of the complexity. |
chriscoey
approved these changes
Apr 11, 2024
Co-authored-by: Chris Coey <[email protected]>
Co-authored-by: Chris Coey <[email protected]>
|
Thanks for the review Chris. This is indeed a nasty cone. I'll slowly optimize it. |
|
Nothing from me to add! |
|
Well since everyone approves can someone merge it? |
|
Oh I assumed you were able to merge. Is that not the case? |
|
No, I don't have write access. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove
mul!s that were multiplyingHermitianwithAdjoint, as this is an order of magnitude slower than usual. It doesn't have a significant impact in overall performance, but drastically reduces the allocations ofdder3()(in my test from 819.07 k to 23.77 k).