Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scalarize bridge #664

Merged
merged 9 commits into from
Mar 6, 2019
Merged

Scalarize bridge #664

merged 9 commits into from
Mar 6, 2019

Conversation

joaquimg
Copy link
Member

@joaquimg joaquimg commented Feb 6, 2019

No description provided.

@joaquimg joaquimg mentioned this pull request Feb 6, 2019
Closed
odow
odow reviewed Feb 6, 2019
View reviewed changes
src/Bridges/scalarizebridge.jl Outdated Show resolved Hide resolved
blegat
blegat reviewed Feb 6, 2019
View reviewed changes
src/Bridges/scalarizebridge.jl Outdated Show resolved Hide resolved
src/Bridges/scalarizebridge.jl Outdated Show resolved Hide resolved
src/Bridges/scalarizebridge.jl Outdated Show resolved Hide resolved
src/Bridges/scalarizebridge.jl Outdated Show resolved Hide resolved
src/Bridges/scalarizebridge.jl Outdated Show resolved Hide resolved
src/Bridges/scalarizebridge.jl Show resolved Hide resolved
src/Bridges/scalarizebridge.jl Outdated Show resolved Hide resolved
src/Bridges/scalarizebridge.jl Outdated Show resolved Hide resolved
src/Bridges/scalarizebridge.jl Outdated Show resolved Hide resolved
src/Utilities/functions.jl Outdated Show resolved Hide resolved
@blegat blegat added Submodule: Bridges About the Bridges submodule Type: Enhancement labels Feb 6, 2019
@codecov-io
Copy link

codecov-io commented Feb 7, 2019 •
edited
Loading

Codecov Report

Merging #664 into master will decrease coverage by 0.46%.
The diff coverage is 58.2%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #664      +/-   ##
==========================================
- Coverage   95.67%   95.21%   -0.47%     
==========================================
  Files          52       53       +1     
  Lines        5387     5454      +67     
==========================================
+ Hits         5154     5193      +39     
- Misses        233      261      +28
Impacted Files Coverage Δ
src/Bridges/Bridges.jl 100% <100%> (ø) ⬆️
src/Utilities/functions.jl 95.39% <53.33%> (-2.82%) ⬇️
src/Bridges/scalarizebridge.jl 61.11% <61.11%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bf97a6...1c52f79. Read the comment docs.

blegat
blegat reviewed Mar 3, 2019
View reviewed changes
src/Utilities/functions.jl Outdated Show resolved Hide resolved
@blegat blegat added the Submodule: Tests About the Tests submodule label Mar 3, 2019
@blegat blegat added this to the v0.8.3 milestone Mar 5, 2019
@blegat blegat changed the title [WIP] Scalarize bridge Scalarize bridge Mar 5, 2019
@blegat blegat mentioned this pull request Mar 5, 2019
Merged
@mlubin
Copy link
Member

mlubin commented Mar 5, 2019 •
edited
Loading

Let me know if my review is needed, otherwise I'm not planning on reviewing this and @blegat can merge when ready.

@blegat blegat merged commit 2402c51 into master Mar 6, 2019
@odow odow deleted the jg/scalarize branch March 6, 2019 15:32
@blegat blegat mentioned this pull request Mar 11, 2019
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blegat blegat blegat left review comments

@odow odow odow left review comments

Assignees
No one assigned
Labels
Submodule: Bridges About the Bridges submodule Submodule: Tests About the Tests submodule Type: Enhancement
Milestone
v0.8.3
Development

Successfully merging this pull request may close these issues.
5 participants
@joaquimg @codecov-io @mlubin @blegat @odow