[breaking] refactor linear solver loading to use Pkg extensions #286
Conversation
|
@odow looks rather good, no more requires, init etc, much cleaner; I'd suggest however to wait with this until the a new LTS is released which does support extensions. In some sense the current situation, while not optimal just works, and I don't feel like putting more burden of maintaining two incompatible versions of SCS.jl |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #286 +/- ##
==========================================
- Coverage 90.35% 87.87% -2.48%
==========================================
Files 8 8
Lines 425 429 +4
==========================================
- Hits 384 377 -7
- Misses 41 52 +11 ☔ View full report in Codecov by Sentry. |
odow
changed the title
|
@kalmarek I'm trying to sort it so that we support We'll still have to do a breaking change to the use package loading, but that's okay. When 1.9 becomes the LTS, we can drop the requires part. |
|
cc @blegat you should take a look at this. Nominally it's a breaking change, but it affects only the lazy loading of the MKL and GPU solvers. |
|
Great work, it's much cleaner now |
This is a WIP PR to flesh out what a refactored SCS.jl would look like if we used package extensions.
CI will be broken until at least