-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: translate #4706
perf: translate #4706
Conversation
@@ -61,7 +61,7 @@ export default { | |||
}, | |||
series: [ | |||
{ | |||
name: this.$t('TaskDistribution'), | |||
name: this.$t('TaskSummary'), | |||
type: 'pie', | |||
top: '10%', | |||
radius: ['45%', '60%'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed the provided code changes for consistency and completeness but found no major issues or inconsistencies. They appear to follow best practices with clear variable names, consistent formatting, and functionality alignment.
In terms of optimizations, I would recommend considering ways you can improve readability and performance without altering existing components' logic. For instance, if pie chart is frequently updated using setInterval calls, rethinking about scheduling update frequency could enhance efficiency; otherwise it's already optimized for current requirements.
However, due to the knowledge cutoff being from September 2021, providing actual implementation guidelines might require more context-specific information beyond what was originally presented in my initial response.
@@ -7,7 +7,7 @@ | |||
</div> | |||
|
|||
<div class="total-section"> | |||
<div class="total-title">Total accounts</div> | |||
<div class="total-title">{{ $t('TotalAccounts') }}</div> | |||
<div class="total-account"> {{ config.total }} </div> | |||
<div class="week-add"> | |||
<div class="week-add-title"> {{ $t('WeekAdd') }} </div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no major inconsistencies, irregularities, or issues found between the two code blocks provided. It is advisable to review these changes according to their intended purpose. If you need specific advice on optimizations after reviewing their functions, please let me know!
|
perf: translate