Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: change secret linkage #4710

Merged
merged 1 commit into from
Mar 3, 2025
Merged

perf: change secret linkage #4710

merged 1 commit into from
Mar 3, 2025

Conversation

fit2bot
Copy link
Contributor

@fit2bot fit2bot commented Mar 3, 2025

perf: change secret linkage

@fit2bot fit2bot requested a review from a team March 3, 2025 06:09
@@ -71,6 +72,7 @@ export default {
{
title: this.$t('Total'),
body: {
route: { name: 'AccountChangeSecretExecutionList' },
count: this.data.total_count_change_secret_executions
}
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main difference I noticed is that there seems to be an extra comma before "count" in the second object (lines 70 and 78). It should probably look like this:

{
   title: this.$t('Total'),
   body: {
      count: this.data.total_count_change_secret_executions
   }
}

@feng626 feng626 merged commit 82a4dd5 into pam Mar 3, 2025
3 of 4 checks passed
@feng626 feng626 deleted the pr@pam@change_secret_linkage branch March 3, 2025 06:09
Copy link

sonarqubecloud bot commented Mar 3, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants