Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(breadcrumb): create new component #163

Merged
merged 23 commits into from
Jul 19, 2023
Merged

feat(breadcrumb): create new component #163

merged 23 commits into from
Jul 19, 2023

Conversation

denilsonrp
Copy link
Contributor

@denilsonrp denilsonrp commented Jun 28, 2023 •
edited
Loading

Infos

Task on JuntosID board
Github Issue closes #94

What is being delivered?

  • The breadcrumb component based on Figma and Ionic.

What impacts?

  • Component created;
  • Component tests created;
  • Stories created;

Reversal plan

  • Reset commit to the previous version.

Evidences

Desktop Mobile
screencapture-juntossomosmais-github-io-atomium-pr-preview-pr-163-2023-07-18-18_08_36 screencapture-juntossomosmais-github-io-atomium-pr-preview-pr-163-2023-07-18-18_08_56

@denilsonrp denilsonrp self-assigned this Jun 28, 2023
@denilsonrp denilsonrp marked this pull request as ready for review June 28, 2023 18:40
@denilsonrp denilsonrp requested review from felipefialho, a team, bomffas, giuliatondin and jowjow22 and removed request for a team June 28, 2023 18:40
@tassioFront
Copy link
Contributor

Question:
I got confused looking at Figma's link, because in the first line looks like there is an extra space between the arrows. Your print follows the other lines (which to me, makes sense).

Screen Shot 2023-06-28 at 16 37 48

@github-actions
Copy link
Contributor

github-actions bot commented Jun 28, 2023 •
edited
Loading

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-07-19 15:54 UTC

@felipefialho felipefialho self-requested a review June 28, 2023 21:26
igorwessel
igorwessel previously approved these changes Jun 28, 2023
View reviewed changes
gabrielduete
gabrielduete previously approved these changes Jun 29, 2023
View reviewed changes
@denilsonrp
Copy link
Contributor Author

Question: I got confused looking at Figma's link, because in the first line looks like there is an extra space between the arrows. Your print follows the other lines (which to me, makes sense).

Screen Shot 2023-06-28 at 16 37 48

I don't understand the extra spaces in the first block called _Breadcrumb basics in Figma, so I just ignored it and followed the second block of examples, called [NEW]Breadcrumb. Anyway, I sent a message in this Slack thread questioning it. Based on designers answer, I make some updates.

felipefialho
felipefialho previously approved these changes Jul 18, 2023
View reviewed changes
@felipefialho felipefialho self-requested a review July 18, 2023 16:33
@sonarcloud
Copy link

sonarcloud bot commented Jul 18, 2023

[juntossomosmais_atomium_core] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@denilsonrp denilsonrp merged commit 2ca49a0 into main Jul 19, 2023
3 checks passed
@denilsonrp denilsonrp deleted the feat/breadcrumb branch July 19, 2023 15:49
This was referenced Jul 19, 2023
Merged
Closed
Closed
Merged
This was referenced Jul 31, 2023
Closed
Merged
Merged
felipefialho added a commit that referenced this pull request Aug 3, 2023
@denilsonrp @felipefialho
feat(breadcrumb): create new component (#163)
4ce3b96 
Co-authored-by: felipefialho <[email protected]>
@github-actions github-actions bot mentioned this pull request Aug 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipefialho felipefialho felipefialho approved these changes

@schirrel schirrel schirrel approved these changes

@bomffas bomffas Awaiting requested review from bomffas bomffas was automatically assigned from juntossomosmais/frontenders

@giuliatondin giuliatondin Awaiting requested review from giuliatondin giuliatondin was automatically assigned from juntossomosmais/frontenders

@jowjow22 jowjow22 Awaiting requested review from jowjow22 jowjow22 was automatically assigned from juntossomosmais/frontenders

@gabrielduete gabrielduete Awaiting requested review from gabrielduete

@luiz-ortega luiz-ortega Awaiting requested review from luiz-ortega

@igorwessel igorwessel Awaiting requested review from igorwessel

@tassioFront tassioFront Awaiting requested review from tassioFront

Assignees

@denilsonrp denilsonrp

Labels
components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Component] Breadcrumb
9 participants
@denilsonrp @tassioFront @felipefialho @schirrel @luiz-ortega @igorwessel @gabrielduete @lupy100 @RodrigoRVSN