Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(select): define max-height and add variable to control it #570

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

felipefialho
Copy link
Contributor

Task

What is being delivered?

  • Add 250px to default max-height to select
  • Create --select-max-height to control size inside projects

What impacts?

We gained more flexibility to control the size of the element

Evidences

image

Copy link

sonarcloud bot commented Sep 12, 2024

Quality Gate Passed Quality Gate passed for 'juntossomosmais_atomium_core'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented Sep 12, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-09-12 18:33 UTC

@felipefialho felipefialho merged commit 7917638 into main Sep 12, 2024
4 checks passed
@felipefialho felipefialho deleted the fix/select-height branch September 12, 2024 18:31
@github-actions github-actions bot mentioned this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants