Skip to content
This repository has been archived by the owner on Sep 25, 2024. It is now read-only.

Check onchain metadata #1528

Merged
merged 9 commits into from
Feb 19, 2024
Merged

Check onchain metadata #1528

merged 9 commits into from
Feb 19, 2024

Conversation

randomshinichi
Copy link
Collaborator 

$ yarn validate-PR (validated-tokens.csv contains an invalid mint)
FATAL ERROR: could not find metadata for one of these tokens (6JQq2qS67K4L5xQ3xUTinCyxzdPeZQG1R1ipK8jrY7gc). This means there was an account that wasn't a token mint.
No More Duplicate Symbols: 0 (18 exceptions)
Duplicate Mints: 0
Attempts to Add Multiple Tokens: 0
Invalid Mint Addresses: 0
Not Community Validated: 0 (612 exceptions)
Edits to Existing Tokens: 0
Issues with Symbols in Added Tokens: 0
Onchain Metadata Mismatches: 1
error Command failed with exit code 1.

Sample output (from unittests)

Metadata does not match on-chain data: 8A9HYfj9WAMgjxARWVCJHAeq9i8vdN9cerBmqUamDj7U Name mismatch Expected: Elementerra, Found: Elementum

stdout | src/utils/validate.spec.ts > newTokensHaveMatchingOnchainMeta() works
Metadata does not match on-chain data: DezXAZ8z7PnrnRJjz3wXBoRgixCa6xjnB7YaB1pPB263 Name mismatch Expected: KiKI Token, Found: Bonk
Metadata does not match on-chain data: DezXAZ8z7PnrnRJjz3wXBoRgixCa6xjnB7YaB1pPB263 Symbol mismatch Expected: KIKI, Found: Bonk

stdout | src/utils/validate.spec.ts > newTokensHaveMatchingOnchainMeta() works
Metadata does not match on-chain data: DezXAZ8z7PnrnRJjz3wXBoRgixCa6xjnB7YaB1pPB263 URI mismatch Expected: https://arweave.net/8mAKLjGGmjKTnmcXeyr3pr7iX13xXVjJJiL6RujDbSPV, Found: https://arweave.net/QPC6FYdUn-3V8ytFNuoCS85S2tHAuiDblh6u3CIZLsw
Metadata does not match on-chain data: DezXAZ8z7PnrnRJjz3wXBoRgixCa6xjnB7YaB1pPB263 Decimals mismatch Expected: 9, Found: 5

@randomshinichi randomshinichi changed the title Check metadata Check onchain metadata Feb 15, 2024
@randomshinichi
WIP newTokensHaveMatchingOnchainMeta() checks decimals against Solana…
884095f 
… and Name, Symbol with Metaplex metadata (token 2022 not ready yet)
@randomshinichi
newTokensHaveMatchingOnchainMeta() works with unittests for findAdded…
7508d79 
…Tokens()
@randomshinichi
removed dummy data in newTokensHaveMatchingOnchainMeta()
5a61309
@randomshinichi
working Token2022, Token+metaplex fetching. going to refactor for bul…
8c57a71 
…k RPC calling and missing token metadata trickledown instead of throwing loud errors
@randomshinichi
Token metadata getting works and is robust with unittests
14f4fce 
moved to metadata.ts
newTokensHaveMatchinOnchainMeta() untested
@randomshinichi
token metadata validation is good to go
260fcf1
@randomshinichi
inlined tests were messing up typescript compilation. using vite as a…
c79ef9f 
… runner should solve this, but for now just move tests to a different file and use vitest for testing and normal TS for running.

newTokensHaveMatchinOnchainMeta() now throws an error if an address is provided that isn't a mint.
@randomshinichi
add WHALES as exception for duplicate-symbols check
eb6d07e
9yoi
9yoi previously approved these changes Feb 16, 2024
View reviewed changes
@9yoi 9yoi merged commit f153578 into main Feb 19, 2024
1 check passed
@9yoi 9yoi deleted the check-metadata branch February 19, 2024 06:28
vishalsinghji pushed a commit to vishalsinghji/token-list that referenced this pull request May 25, 2024
@randomshinichi @9yoi @vishalsinghji
Check onchain metadata (jup-ag#1528)
6a2040f 
* WIP newTokensHaveMatchingOnchainMeta() checks decimals against Solana and Name, Symbol with Metaplex metadata (token 2022 not ready yet)

* newTokensHaveMatchingOnchainMeta() works with unittests for findAddedTokens()

* removed dummy data in newTokensHaveMatchingOnchainMeta()

* working Token2022, Token+metaplex fetching. going to refactor for bulk RPC calling and missing token metadata trickledown instead of throwing loud errors

* Token metadata getting works and is robust with unittests
moved to metadata.ts
newTokensHaveMatchinOnchainMeta() untested

* token metadata validation is good to go

* inlined tests were messing up typescript compilation. using vite as a runner should solve this, but for now just move tests to a different file and use vitest for testing and normal TS for running.

newTokensHaveMatchinOnchainMeta() now throws an error if an address is provided that isn't a mint.

* add WHALES as exception for duplicate-symbols check

---------

Co-authored-by: mei <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@9yoi 9yoi 9yoi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@randomshinichi @9yoi