🚦 set CONTENT_CDN_HOST in env of development server #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwkoch
approved these changes
Apr 2, 2024
|
@stevejpurves how does this work with the The host variable is always set to localhost in that block to get around an earlier bug. Does the host variable set both the app and content servers? It looks like this is only targeting the content server? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are to support the fix in jupyter-book/myst-theme#346 where url rewriting should honor the HOST variable used to start the
mystmddevelopment server.This PR also changes the existing log messages to accurately report the usage of HOST rather than always citing
localhost