📑 Use glossarium to support glossaries in typst
#1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rowanc1 can you remember what we concluded here about next steps? |
|
Can we hold off on merging this for about a month? We are going to do significant work on Typst exports for SciPy in July, I would like to tackle it then. If you want to merge in before, I think putting it behind a feature flag would be the addition I would want to see! |
|
@rowanc1 we spoke about reducing the scope of this. Now that SciPy is over, can we just merge as-is? |
|
We are starting to build out the SciPy Typst themes now. @fwkoch merged the first of that earlier this week. Hoping will come back to this over the next few weeks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a glossary handler to the
myst-to-typstpackage. I would like to have used the existingdefinitionListhandling logic, but it's not possible to naively label the keys. Glossarium works around this by embedding each entry in a figure.Right now this generates
#gls("term")syntax instead of@term. This should be pretty simple to do, we just need to normalise the identifier.This PR encodes the assumption that the
identifierof a term starts withterm. Can we assume this? There is a fallback in any case.Fixes #944