🧹 Clean up nodeenv and add CI tests
#1561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
agoose77
commented
Oct 3, 2024
.github/workflows/python-ci.yml
Outdated
Comment on lines
3
to
12
| on: | ||
| push: | ||
| #branches: [main, ci-*] | ||
| #paths: | ||
| # - 'packages/mystmd-py/**' | ||
| pull_request: | ||
| #branches: [main] | ||
| #paths: | ||
| # - 'packages/mystmd-py/**' | ||
| workflow_dispatch: |
There was a problem hiding this comment.
These will be un-commented once the tests pass.
rowanc1
changed the title
nodeenv and add CI testsnodeenv and add CI tests
|
Feel free to take this over the line whenever you feel like it @agoose77! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some recent refactoring work, the
nodeenvintegration added some duplicate code. This PR removes that, and ensures that we're testing its usage.I couldn't find an elegant way to create an environment without Node.js without using Docker. There's also Nix, but I know that it is not something people are familiar with. Although I am confident it would be simple to understand, if it goes wrong, things get hard.