Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rename causing blanking of raw cell conents #1086

Merged
merged 4 commits into from
Jun 21, 2024
Merged

Fix rename causing blanking of raw cell conents #1086

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e9b5954
Fix raw cell rename issue
krassowski May 26, 2024
66aa665
Deduplicate yarn
krassowski May 26, 2024
0052b99
Lint
krassowski May 26, 2024
d86ee64
Revert yarn lock changes
krassowski May 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/jupyterlab-lsp/src/edits.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,8 +189,12 @@ export class EditApplicator {
if (!editor) {
throw Error('Editor is not accessible');
}
if (editor.host.closest('.jp-MarkdownCell')) {
if (
editor.host.closest('.jp-MarkdownCell') ||
editor.host.closest('.jp-RawCell')
) {
// Workaround for https://github.com/jupyter-lsp/jupyterlab-lsp/issues/1008
// and for https://github.com/jupyter-lsp/jupyterlab-lsp/issues/1084
// briefly, the rewrite for JupyterLab 4.0 added Markdown cell support, but they
// are extracted without trace in the top-level document. Here we avoid editing
// any markdown cell. Instead the clean solution would be to add an anchor marker
Expand Down
Loading