Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pydantic v2 #330

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Use pydantic v2 #330

merged 1 commit into from
Jul 13, 2023

Conversation

davidbrochart
Copy link
Collaborator

No description provided.

@davidbrochart
Copy link
Collaborator Author

check_release fails with:

pydantic_core._pydantic_core.PydanticSerializationError: Error serializing to JSON: OverflowError: Python int too large to convert to C long

@blink1073 could it be that jupyter-releaser is not compatible with Pydantic v2?

@blink1073
Copy link

Releaser v2 is compatible, you're pulling from the v1 tag.

@davidbrochart
Copy link
Collaborator Author

Thanks!

@davidbrochart davidbrochart merged commit bdca3e0 into jupyter-server:main Jul 13, 2023
10 of 13 checks passed
@davidbrochart davidbrochart deleted the pydantic2 branch July 13, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidbrochart @blink1073