Skip to content

Commit

Permalink
Restore the ability to override the HTTP port a configurable serverap…
Browse files Browse the repository at this point in the history
…p listens on

When invoking the `jp_configurable_serverapp` fixture, there are multiple keyword arguments supported for overriding the values specified by other fixtures.

One of those keyword arguments, `http_port`, is never used. I believe this was accidentally broken by #33 where multiple variables named `http_port` referencing a provided fixture were renamed to `jp_http_port`.

However, that change also modified one instance of `http_port` that was not a reference to the fixture, but rather a reference to the keyword argument with that same name.

This change fixes that by undoing that one line of the change.
  • Loading branch information
ojarjur authored Sep 6, 2024
1 parent b73fd26 commit 7ac1ae4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pytest_jupyter/jupyter_server.py
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ def _configurable_serverapp(
app = ServerApp.instance(
# Set the log level to debug for testing purposes
log_level="DEBUG",
port=jp_http_port,
port=http_port,
port_retries=0,
open_browser=False,
base_url=base_url,
Expand Down

0 comments on commit 7ac1ae4

Please sign in to comment.