Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing request_timeout to client_fetch #67

Merged

Conversation

afbarbaro
Copy link
Contributor

When using the jp_fetch function on pytest tests, the request timeout is hardcoded to 20 seconds. This change allows the users to pass a timeout as a method argument, still defaulting to 20 if it's not given.

I have some tests for endpoints that sometimes can take more than 20s and this change will make them pass.

Copy link

welcome bot commented Nov 24, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@afbarbaro
Copy link
Contributor Author

@blink1073 sorry to ask something silly, I've not contributed to this project before, so I'm not sure what I need to do to get reviewers on it and go through the PR feedback cycle, approval, and eventually merge this.
Let me know what I need to do.
Thanks

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@blink1073 blink1073 merged commit e7fc7a2 into jupyter-server:main Dec 5, 2023
25 checks passed
Copy link

welcome bot commented Dec 5, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@blink1073
Copy link
Contributor

I'll make a release with this change tomorrow.

@blink1073 blink1073 added the enhancement New feature or request label Dec 5, 2023
@afbarbaro
Copy link
Contributor Author

I'll make a release with this change tomorrow.

Awesome! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants