Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add async version of jp_server_cleanup fixture #70

Closed

Conversation

davidbrochart
Copy link
Contributor

Copy link

welcome bot commented Dec 11, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@davidbrochart
Copy link
Contributor Author

Actually this is not enough to fix jupyterlab/jupyter-collaboration#221.
Maybe autouse should also be disabled for jp_server_cleanup, and each test should choose the right fixture depending if it's async or not? It seems impossible for the right version to be automatically picked up.

@davidbrochart davidbrochart deleted the async-cleanup branch December 12, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant