Refactor transform logic to make it column name based #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinRenou
force-pushed
the
transform_column_names
branch
7 times, most recently
from
86fb1d1 to
c7360df
Compare
Signed-off-by: martinRenou <[email protected]>
martinRenou
force-pushed
the
transform_column_names
branch
from
c7360df to
8901472
Compare
gaborbernat
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renderers are column name based, transforms were not. This PR makes the API more homogeneous by making the transforms column based.
This is backward compatible in the Python API.
This will make #496 easier (hiding columns messes up the indexing, hiding column by name will work better)