Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix choropleth used without initial choro_data #1038

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HaudinFlorence
Copy link
Contributor

@HaudinFlorence HaudinFlorence commented Aug 16, 2022

Propose a solution for using Choropleth layer without giving an initial choro_data. Fix issue #934
In this implementation, when no dict is given for choro_data, a dict is built from the key of the geo_data and the affected value is zero for all keys. A check is performed to see wether all values of choro_data are identical (that means there is no geographical variation in the observed data that is not very likely) a warning is raised and the color and opacity attributed are set to the nan default ones.

no_initial_choro_data

@HaudinFlorence HaudinFlorence marked this pull request as ready for review August 16, 2022 17:46
@HaudinFlorence HaudinFlorence marked this pull request as draft August 17, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant