Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix map not displaying in jupyterlite. #1040

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

HaudinFlorence
Copy link
Contributor

Fix issue #1020. The first solution proposed by @jtpio in this issue is implemented, that is "pinning the version with piplite.install('ipyleaflet==0.17') in the notebook."

@@ -8,7 +8,7 @@
"outputs": [],
"source": [
"import piplite\n",
"await piplite.install('ipyleaflet')"
"await piplite.install('ipyleaflet == 0.17')"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the extra spaces around the == could be trimmed?

Suggested change
"await piplite.install('ipyleaflet == 0.17')"
"await piplite.install('ipyleaflet==0.17')"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.This has been changed.

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks @HaudinFlorence for fixing this 👍

Just left a minor comment above.

@martinRenou
Copy link
Member

Another way to fix this could be to use xeus-python :D

@HaudinFlorence
Copy link
Contributor Author

HaudinFlorence commented Aug 19, 2022

Another way to fix this could be to use xeus-python :D

I would like to do it but I don't know how.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants