Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add draw controls test #1178

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maartenbreddels
Copy link
Member

This is using solara to run the test with a live frontend.

These things are difficult to test with galata, since we test user interaction.

In light of a future PR (see #1165 for details) I think it's good to test one of the more complex widgets.

This is using solara to run the test with a live
frontend.
@maartenbreddels
Copy link
Member Author

Failure is most likely not due to this PR.

@martinRenou
Copy link
Member

Thanks Maarten!

I'm a bit skeptical about adding a new way to do visual regression testing to the repo. I'd prefer we either stick to galata or we move entirely to using solara testing.

These things are difficult to test with galata

you more or less have the same API with playwright

@maartenbreddels
Copy link
Member Author

Hi Martin,

you more or less have the same API with playwright

Yes, but I've noticed pure python people having no idea what to do with the ui-tests, and have no idea how it works (it took me a while). Building tests that do interaction (like click a button) are basically a no-go for more Python people.

That said, I totally understand not wanting two systems. I could probably rewrite the notebook tests to use the solara test framework, but that would mean we don't have such a nice HTML report, since that is not available for Python yet: microsoft/playwright-python#1296

Let me know what you think? Do you think its worth to give up the HTML report to have the option to do more complex UI tests from Python?

cheers,

Maarten

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants