Make Leaflet-Geoman ignore created layers by default #1220
Conversation
* This is more sensible and aligned with the other examples.
|
Let me know if and how I should add an entry in |
|
The docs failure is unrelated to the changes, see https://app.readthedocs.org/projects/ipyleaflet/builds/25076525/#238126839--263
I could build the docs locally commenting out the corresponding example, to verify how the updated Geoman Draw Control page looks. |
There was a problem hiding this comment.
The change was even simpler than I thought, no comments there. I tried it out and everything seems to work as expected.
There seem to be some commits that are unrelated to the PR, but I'll let @martinRenou be the judges of whether that is acceptable
| =================== | ||
|
|
||
| ``GeomanDrawControl`` allows one to draw various shapes on the map. | ||
| ``GeomanDrawControl`` allows one to draw various shapes on the map. |
There was a problem hiding this comment.
These two lines in seem unrelated to the commit they are in.
There was a problem hiding this comment.
You are right, these two minor changes came when I rendered the fix to the list locally, since my IDE drops trailing spaces and there was a warning in Sphinx about the nr of = that I took the chance of fixing.
I should probably have at least added an additional line in the commit message stating stg like "Also fix some minor cosmetic RST formatting."
If you prefer to have a more accurate commit history, I am happy to force-push them as individual changes. Let me know, no big deal for me.
Fixes #1215, see discussion therein.
The possible usage of
pm_ignore=Falseis now also included in the in 'Geoman Draw Control' documentation page (with some minor adjustments to existing content)