Better tests directory structure #2231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathbunnyru
force-pushed
the
reorganize_tests
branch
from
c6096f3 to
ecfe2c9
Compare
|
I checked - number of tests for aarch64-base stays the same. |
mathbunnyru
force-pushed
the
reorganize_tests
branch
2 times, most recently
from
35a6f14 to
e4f6c3e
Compare
mathbunnyru
commented
Feb 21, 2025
| @pytest.fixture(scope="function") | ||
| def container(docker_client: docker.DockerClient, image_name: str) -> Container: |
There was a problem hiding this comment.
This was a bug, we don't return Container, but our TrackedContainer wrapper
mathbunnyru
force-pushed
the
reorganize_tests
branch
2 times, most recently
from
7450d7a to
43608ba
Compare
mathbunnyru
force-pushed
the
reorganize_tests
branch
from
43608ba to
a72e784
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket if applicable
Checklist (especially for first-time contributors)