Clarify container.remove() behaviour #2235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathbunnyru
commented
Feb 22, 2025
| @@ -39,9 +39,8 @@ def __exit__( | |||
| ) -> None: | |||
| assert self.container is not None | |||
| LOGGER.info(f"Removing container {self.container.name} ...") | |||
| if self.container: | |||
There was a problem hiding this comment.
assert above means that this if is always true
mathbunnyru
commented
Feb 22, 2025
Comment on lines
+95
to
+100
| if self.container is None: | ||
| LOGGER.info("No container to remove") | ||
| else: | ||
| LOGGER.info(f"Removing container {self.container.name} ...") | ||
| self.container.remove(force=True) | ||
| LOGGER.info(f"Container {self.container.name} removed") |
There was a problem hiding this comment.
Just better logs.
There is some sort of code duplication between DockerRunner and TrackedContainer, but for now let's keep tagging/ and tests dir completely independent of each other.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket if applicable
Checklist (especially for first-time contributors)