Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate RefResolver to referencing.Registry #80

Merged
merged 15 commits into from
Jul 29, 2023

Conversation

hbcarlos
Copy link
Contributor

@hbcarlos hbcarlos commented Jul 12, 2023

Fixes warning:

DeprecationWarning: jsonschema.RefResolver is deprecated as of v4.18.0, in favor of the https://github.com/python-jsonschema/referencing library, which provides more compliant referencing behavior as well as more flexible APIs for customization. A future release will remove RefResolver. Please file a feature request (on referencing) if you are missing an API for the kind of customization you need.

See: https://github.com/jupyterlab/jupyter-collaboration/actions/runs/5533655455/jobs/10097501386?pr=175#step:6:97

This PR is ready, but merging will:

@hbcarlos hbcarlos marked this pull request as ready for review July 18, 2023 13:40
jupyter_events/schema.py Outdated Show resolved Hide resolved
jupyter_events/validators.py Outdated Show resolved Hide resolved
@blink1073 blink1073 enabled auto-merge (squash) July 29, 2023 03:23
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you both!

@blink1073
Copy link
Contributor

I'll cut a release early next week.

@blink1073 blink1073 merged commit 56e7d26 into jupyter:main Jul 29, 2023
22 checks passed
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Jul 30, 2023
https://build.opensuse.org/request/show/1101394
by user bnavigator + dimstar_suse
- Add jupyter_events-pr80-jsonschema-referencing.patch
  * gh#jupyter/jupyter_events#80
  * Avoid test suite errors in consuming packages because of
    jsonschema DeprecationWarning
- Remove workaround for rpmlint parser crash (forwarded request 1101393 from bnavigator)
@hbcarlos
Copy link
Contributor Author

Thank you for finishing the PR @blink1073!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants