Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip test and CI workflow for some python versions #300

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Skip test and CI workflow for some python versions #300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5218e0f
skip test_display_isolation for python 3.8+ passes locally but fails …
RRosio Sep 19, 2024
7054a4c
skip workflow on Python 3.7 as hatch fails to install
RRosio Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/pythonpackage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@ jobs:
matrix:
os: [ubuntu-22.04, macos-12, windows-2022]
python-version: ["3.7", "3.8", "3.9", "3.10"]
exclude:
- os: ubuntu-22.04
python-version: "3.7"
- os: macos-12
python-version: "3.7"
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down
4 changes: 3 additions & 1 deletion nbclassic/tests/end_to_end/test_display_isolation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,10 @@


from .utils import EDITOR_PAGE
import pytest
import sys


@pytest.mark.skipif(sys.version_info >= (3, 8), reason="Fails in Python 3.8+")
def test_display_isolation(notebook_frontend):
import_ln = "from IPython.core.display import HTML, SVG, display, display_svg"
notebook_frontend.edit_cell(index=0, content=import_ln)
Expand Down
Loading