Skip to content

Commit

Permalink
Fix some test wait conditions
Browse files Browse the repository at this point in the history
  • Loading branch information
jtpio committed Oct 3, 2022
1 parent 6cc6a10 commit 4200fb5
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
3 changes: 3 additions & 0 deletions ui-tests/test/general.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ test.describe('General', () => {
".jp-Notebook-ExecutionIndicator[data-status='idle']"
);

// wait for the checkpoint indicator to be displayed
await page.waitForSelector('.jp-NotebookCheckpoint');

// force switching back to command mode to avoid capturing the cursor in the screenshot
await page.evaluate(async () => {
await window.jupyterapp.commands.execute('notebook:enter-command-mode');
Expand Down
4 changes: 1 addition & 3 deletions ui-tests/test/notebook.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { expect } from '@playwright/test';

import { test } from './fixtures';

import { runAndAdvance, waitForKernelReady } from './utils';
import { runAndAdvance } from './utils';

const NOTEBOOK = 'example.ipynb';

Expand Down Expand Up @@ -70,8 +70,6 @@ test.describe('Notebook', () => {
);
await page.goto(`notebooks/${tmpPath}/${notebook}`);

await waitForKernelReady(page);

// execute the first cell
await runAndAdvance(page);
await page
Expand Down

0 comments on commit 4200fb5

Please sign in to comment.