Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JupyterCAD #10

Merged
merged 6 commits into from
Jul 2, 2024
Merged

Update JupyterCAD #10

merged 6 commits into from
Jul 2, 2024

Conversation

martinRenou
Copy link
Member

No description provided.

@martinRenou martinRenou added the enhancement New feature or request label Jul 1, 2024
@trungleduc
Copy link
Member

We might need to update the test script to click on the ok button

video.webm

@martinRenou
Copy link
Member Author

Thanks for looking into it, I'll make the change.

It's annoying though that playwright did not report a video, or did I miss it?

@martinRenou
Copy link
Member Author

martinRenou commented Jul 2, 2024 •
edited
Loading

please update snapshots!

@martinRenou martinRenou merged commit c7b2060 into jupytercad:main Jul 2, 2024
7 checks passed
@martinRenou martinRenou deleted the update_jcad branch July 2, 2024 08:51
@trungleduc
Copy link
Member

Thanks for looking into it, I'll make the change.

It's annoying though that playwright did not report a video, or did I miss it?

there are some changes in lab 4.2 about galata. I pinned lab 4.1.2 in the UI test for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinRenou @trungleduc