Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pushing Helm charts to OCI registries, rather than just Github Pages-based chart repos. #187

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

bleggett
Copy link
Contributor

@bleggett bleggett commented Sep 8, 2022

As per #186

This adds support for publishing Helm charts to an OCI registry.

A configuration like

charts:
  - name: binderhub
    repo:
      oci: ghcr.io/jupyterhub
      prefix: helm-charts

will push the binderhub chart to to Github's GHCR OCI registry under the path ghcr.io/jupyterhub/helm-charts/binderhub

This should work for Amazon's OCI repo (ECR), Google's OCI repo (GCR), and Docker's self-hosted registry image, all of which are OCI-compliant registries.

Additionally, this PR adds support for a basePath key under chart definitions, for repos that keep charts under a specific directory structure - this is roughly analogous to contextPath for images.

This means chartpress.yaml can be kept in the repo root, and users have more freedom as to how and where charts and images are kept relative to each other, as well as to chartpress.yaml itself.

@welcome
Copy link

welcome bot commented Sep 8, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant