Fail loudly if GRAFANA_TOKEN or jsonnet isn't available
#124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
changed the title
GRAFANA_TOKEN or jsonnet isn't available
consideRatio
force-pushed
the
pr/fail-warn-loudly
branch
from
cc27d67
to
6d4b181
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jsonnet- golang version - isn't on path #112The deploy.py script doesn't work if either
GRAFANA_TOKENisn't set, or ifjsonnetisn't available on path. This PR makes the failure verbose instead of showing up as an error harder to read later.It doesn't fail if go-jsonnet isn't detected, but warns - because maybe it works at some time in the future with the non-golang based version of
jsonnetfor example.Related