Remove always failing linter #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was introduced in jupyterhub#106, and has never passed. I don't think we should have a test that is always expected to fail. If it should be re-introduced, it should be done in such a way that whatever changes are needed to make it pass should be part of the PR. This only reverts the linter, but keeps the rendering test - as that would help us catch possible jsonnet syntax issues.
minrk
approved these changes
Jul 25, 2024
|
Thank you @minrk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was introduced in #106, and has never passed. I don't think we should have a test that is always expected to fail.
If it should be re-introduced, it should be done in such a way that whatever changes are needed to make it pass should be part of the PR.
This only reverts the linter, but keeps the rendering test - as that would help us catch possible jsonnet syntax issues.