Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grafonnet import paths to absolute import paths #139

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

raphaelzoellner
Copy link
Contributor

@raphaelzoellner raphaelzoellner commented Aug 27, 2024

Context

Users integrating the dashboards into mixins might use colliding relative import paths.

This might be for example the case for:
https://github.com/grafana/grafonnet
https://github.com/grafana/grafonnet-lib (subdir grafonnet)

Using absolute import paths instead of relative import paths should resolve this collision for dependencies in distinct repositories.

Description

This PR updates the relative import paths grafonnet/main.libsonnet to absolute import paths github.com/grafana/grafonnet/gen/grafonnet-v10.4.0/main.libsonnet to avoid jsonnet import path collisions.

@consideRatio
Copy link
Member

Thank you @raphaelzoellner, lets do it!

There is a symlink file in vendor/ pointing to the version used, and that remains an option for externally managed .jsonnet dashboards to be rendered without pinning the grafonnet version explicitly. I figure we let that remain there as this PR currently does.

@consideRatio consideRatio merged commit 1f5fa1c into jupyterhub:main Sep 25, 2024
3 checks passed
@consideRatio
Copy link
Member

I appreciate the work you put into the writing a context for this PR! I don't understand golang aspects well as I haven't spent much time working with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants