Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add local dev deployment for LTI 1.3 #130

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Add local dev deployment for LTI 1.3 #130

wants to merge 11 commits into from

Conversation

martinclaus
Copy link
Collaborator

@martinclaus martinclaus commented Feb 24, 2023 •
edited
Loading

This adds a docker compose deployment and instructions and configuration to set up the TAO LTI 1.3 devKit as the LTI platform to initiate the login flow.

The goal is to improve testing of the LTI 1.3 Authenticator both locally and via CI.

@martinclaus martinclaus marked this pull request as draft February 24, 2023 12:27
@martinclaus
Copy link
Collaborator Author

It seems that the LTI 1.3 library on which the devkit is build isn't correctly implementing the LTI 1.3 specifications, or more precisely, the OICD Connect specifications. Issues (oat-sa/lib-lti1p3-core#154, oat-sa/lib-lti1p3-core#160) are opened.

@martinclaus martinclaus linked an issue Mar 30, 2023 that may be closed by this pull request
Improve testing by starting up an LTI 1.3 endpoint in the CI system #117
Open
@danielmcquillen
Copy link

I noticed that a c.LTI13Authenticator.jwks_endpoint configuration setting is used in the docs but this PR has a c.LTI13Authenticator.endpoint setting ... are those both valid?

@martinclaus
Copy link
Collaborator Author

I noticed that a c.LTI13Authenticator.jwks_endpoint configuration setting is used in the docs but this PR has a c.LTI13Authenticator.endpoint setting ... are those both valid?

@danielmcquillen This PR is quite outdated and stalled. The c.LTI13Authenticator.endpoint setting does not exist in more recent releases anymore. The correct one to use is c.LTI13Authenticator.jwks_endpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
LTI13Authenticator maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve testing by starting up an LTI 1.3 endpoint in the CI system
3 participants
@martinclaus @danielmcquillen @consideRatio