Merge pull request #2838 from manics/aws-curvenote-binder

Curvenote: Add GitHub tokens, and publish events
jupyterhub · Nov 23, 2023 · d66a3f1 · d66a3f1
2 parents e3fd889 + ff7151d
commit d66a3f1
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 14 deletions.
diff --git a/config/curvenote.yaml b/config/curvenote.yaml
@@ -28,31 +28,26 @@ binderhub:
         secretKeyRef:
           name: curvenote-binderhub-container-registry-helper
           key: auth_token
+    GOOGLE_APPLICATION_CREDENTIALS: /secrets/service-account.json
 
   registry:
     url: 166088433508.dkr.ecr.us-east-2.amazonaws.com
     username: ""
     password: ""
 
-  # extraVolumes:
-  #   - name: secrets
-  #     secret:
-  #       secretName: events-archiver-secrets
-  # extraVolumeMounts:
-  #   - name: secrets
-  #     mountPath: /secrets
-  #     readOnly: true
-  # extraEnv:
-  #   GOOGLE_APPLICATION_CREDENTIALS: /secrets/service-account.json
+  extraVolumes:
+    - name: secrets
+      secret:
+        secretName: events-archiver-secrets
+  extraVolumeMounts:
+    - name: secrets
+      mountPath: /secrets
+      readOnly: true
 
   extraPodSpec:
     priorityClassName: binderhub-core
 
   extraConfig:
-    01-eventlog: |
-      # Disabled until GOOGLE_APPLICATION_CREDENTIALS secret is available
-      # and secrets/events-archiver/curvenote.json is created
-
     10-external-registry-helper: |
       import json
       from os import getenv

diff --git a/secrets/config/curvenote.yaml b/secrets/config/curvenote.yaml