Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example docker compose environment and related docs #158

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alexleach
Copy link
Contributor

Hello!

As mentioned in a comment I made yesterday, I thought the documentation and example folder could benefit from some information regarding docker-compose. It's what I use for my jupyterhub environment, and I think works well for single server environments.

Some suggested example configuration and documentation files are attached.

Kind regards,
Alex

@manics
Copy link
Member

manics commented Feb 22, 2023

We've got a example docker deployment repo https://github.com/jupyterhub/jupyterhub-deploy-docker so that's another option.

What does everyone else think? Have this example in this repo, or add it to a subdirectory of https://github.com/jupyterhub/jupyterhub-deploy-docker so that repo becomes a set of docker related deployment examples?

@GeorgianaElena
Copy link
Member

Hmm, good point!

What does everyone else think? Have this example in this repo, or add it to a subdirectory of https://github.com/jupyterhub/jupyterhub-deploy-docker so that repo becomes a set of docker related deployment examples?

I believe having it in https://github.com/jupyterhub/jupyterhub-deploy-docker makes more sense so my vote goes towards that. I think for trefik-proxy it makes sense to just reference the example from its docs.

@manics
Copy link
Member

manics commented Feb 22, 2023

I've opened a PR to move the existing example into a subdirectory, so it'll be easier to add more examples
jupyterhub/jupyterhub-deploy-docker#117

@alexleach
Copy link
Contributor Author

Hiya. I was just wondering about this. I'm fine with moving it to the docker-compose example repo, but don't think there's anything I can do until that PR is merged, is there?

Cheers,
Alex

@manics
Copy link
Member

manics commented Mar 17, 2023

https://github.com/jupyterhub/jupyterhub-deploy-docker has been refactored to make it easier to add new examples. The README will require some reorganisation, or splitting into separate files (e.g. one README per example?), depending on exactly how the additional examples are documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants