-
-
Notifications
You must be signed in to change notification settings - Fork 31
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Add forking API (#394) * Add forking API * Add GET forks of root * Add fork Jupyter events * Replace query parameter merge=1 with merge=true * Add fork title and description * Add JS APIs --------- Co-authored-by: David Brochart <[email protected]>
- Loading branch information
1 parent
47811fd
commit a3ab041
Showing
10 changed files
with
413 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
/* | ||
* Copyright (c) Jupyter Development Team. | ||
* Distributed under the terms of the Modified BSD License. | ||
*/ | ||
|
||
import { ICollaborativeDrive } from '@jupyter/collaborative-drive'; | ||
import { | ||
ForkManager, | ||
IForkManager, | ||
IForkManagerToken | ||
} from '@jupyter/docprovider'; | ||
|
||
import { | ||
JupyterFrontEnd, | ||
JupyterFrontEndPlugin | ||
} from '@jupyterlab/application'; | ||
|
||
export const forkManagerPlugin: JupyterFrontEndPlugin<IForkManager> = { | ||
id: '@jupyter/docprovider-extension:forkManager', | ||
autoStart: true, | ||
requires: [ICollaborativeDrive], | ||
provides: IForkManagerToken, | ||
activate: (app: JupyterFrontEnd, drive: ICollaborativeDrive) => { | ||
const eventManager = app.serviceManager.events; | ||
const manager = new ForkManager({ drive, eventManager }); | ||
return manager; | ||
} | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,96 @@ | ||
// Copyright (c) Jupyter Development Team. | ||
// Distributed under the terms of the Modified BSD License. | ||
|
||
import { ICollaborativeDrive } from '@jupyter/collaborative-drive'; | ||
import { | ||
ForkManager, | ||
JUPYTER_COLLABORATION_FORK_EVENTS_URI | ||
} from '../forkManager'; | ||
import { Event } from '@jupyterlab/services'; | ||
import { Signal } from '@lumino/signaling'; | ||
import { requestAPI } from '../requests'; | ||
jest.mock('../requests'); | ||
|
||
const driveMock = { | ||
name: 'rtc', | ||
providers: new Map() | ||
} as ICollaborativeDrive; | ||
const stream = new Signal({}); | ||
const eventManagerMock = { | ||
stream: stream as any | ||
} as Event.IManager; | ||
|
||
describe('@jupyter/docprovider', () => { | ||
let manager: ForkManager; | ||
beforeEach(() => { | ||
manager = new ForkManager({ | ||
drive: driveMock, | ||
eventManager: eventManagerMock | ||
}); | ||
}); | ||
describe('forkManager', () => { | ||
it('should have a type', () => { | ||
expect(ForkManager).not.toBeUndefined(); | ||
}); | ||
it('should be able to create instance', () => { | ||
expect(manager).toBeInstanceOf(ForkManager); | ||
}); | ||
it('should be able to create new fork', async () => { | ||
await manager.createFork({ | ||
rootId: 'root-uuid', | ||
synchronize: true, | ||
title: 'my fork label', | ||
description: 'my fork description' | ||
}); | ||
expect(requestAPI).toHaveBeenCalledWith( | ||
'api/collaboration/fork/root-uuid', | ||
{ | ||
method: 'PUT', | ||
body: JSON.stringify({ | ||
title: 'my fork label', | ||
description: 'my fork description', | ||
synchronize: true | ||
}) | ||
} | ||
); | ||
}); | ||
it('should be able to get all forks', async () => { | ||
await manager.getAllForks('root-uuid'); | ||
expect(requestAPI).toHaveBeenCalledWith( | ||
'api/collaboration/fork/root-uuid', | ||
{ | ||
method: 'GET' | ||
} | ||
); | ||
}); | ||
it('should be able to get delete forks', async () => { | ||
await manager.deleteFork({ forkId: 'fork-uuid', merge: true }); | ||
expect(requestAPI).toHaveBeenCalledWith( | ||
'api/collaboration/fork/fork-uuid?merge=true', | ||
{ | ||
method: 'DELETE' | ||
} | ||
); | ||
}); | ||
it('should be able to emit fork added signal', async () => { | ||
const listener = jest.fn(); | ||
manager.forkAdded.connect(listener); | ||
const data = { | ||
schema_id: JUPYTER_COLLABORATION_FORK_EVENTS_URI, | ||
action: 'create' | ||
}; | ||
stream.emit(data); | ||
expect(listener).toHaveBeenCalledWith(manager, data); | ||
}); | ||
it('should be able to emit fork deleted signal', async () => { | ||
const listener = jest.fn(); | ||
manager.forkDeleted.connect(listener); | ||
const data = { | ||
schema_id: JUPYTER_COLLABORATION_FORK_EVENTS_URI, | ||
action: 'delete' | ||
}; | ||
stream.emit(data); | ||
expect(listener).toHaveBeenCalledWith(manager, data); | ||
}); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,126 @@ | ||
/* | ||
* Copyright (c) Jupyter Development Team. | ||
* Distributed under the terms of the Modified BSD License. | ||
*/ | ||
|
||
import { ICollaborativeDrive } from '@jupyter/collaborative-drive'; | ||
import { URLExt } from '@jupyterlab/coreutils'; | ||
import { Event } from '@jupyterlab/services'; | ||
import { ISignal, Signal } from '@lumino/signaling'; | ||
|
||
import { requestAPI, ROOM_FORK_URL } from './requests'; | ||
import { | ||
IAllForksResponse, | ||
IForkChangedEvent, | ||
IForkCreationResponse, | ||
IForkManager | ||
} from './tokens'; | ||
import { IForkProvider } from './ydrive'; | ||
|
||
export const JUPYTER_COLLABORATION_FORK_EVENTS_URI = | ||
'https://schema.jupyter.org/jupyter_collaboration/fork/v1'; | ||
|
||
export class ForkManager implements IForkManager { | ||
constructor(options: ForkManager.IOptions) { | ||
const { drive, eventManager } = options; | ||
this._drive = drive; | ||
this._eventManager = eventManager; | ||
this._eventManager.stream.connect(this._handleEvent, this); | ||
} | ||
|
||
get isDisposed(): boolean { | ||
return this._disposed; | ||
} | ||
get forkAdded(): ISignal<ForkManager, IForkChangedEvent> { | ||
return this._forkAddedSignal; | ||
} | ||
get forkDeleted(): ISignal<ForkManager, IForkChangedEvent> { | ||
return this._forkDeletedSignal; | ||
} | ||
|
||
dispose(): void { | ||
if (this._disposed) { | ||
return; | ||
} | ||
this._eventManager?.stream.disconnect(this._handleEvent); | ||
this._disposed = true; | ||
} | ||
async createFork(options: { | ||
rootId: string; | ||
synchronize: boolean; | ||
title?: string; | ||
description?: string; | ||
}): Promise<IForkCreationResponse | undefined> { | ||
const { rootId, title, description, synchronize } = options; | ||
const init: RequestInit = { | ||
method: 'PUT', | ||
body: JSON.stringify({ title, description, synchronize }) | ||
}; | ||
const url = URLExt.join(ROOM_FORK_URL, rootId); | ||
const response = await requestAPI<IForkCreationResponse>(url, init); | ||
return response; | ||
} | ||
|
||
async getAllForks(rootId: string) { | ||
const url = URLExt.join(ROOM_FORK_URL, rootId); | ||
const init = { method: 'GET' }; | ||
const response = await requestAPI<IAllForksResponse>(url, init); | ||
return response; | ||
} | ||
|
||
async deleteFork(options: { forkId: string; merge: boolean }): Promise<void> { | ||
const { forkId, merge } = options; | ||
const url = URLExt.join(ROOM_FORK_URL, forkId); | ||
const query = URLExt.objectToQueryString({ merge }); | ||
const init = { method: 'DELETE' }; | ||
await requestAPI(`${url}${query}`, init); | ||
} | ||
getProvider(options: { | ||
documentPath: string; | ||
format: string; | ||
type: string; | ||
}): IForkProvider | undefined { | ||
const { documentPath, format, type } = options; | ||
const drive = this._drive; | ||
if (drive) { | ||
const driveName = drive.name; | ||
let docPath = documentPath; | ||
if (documentPath.startsWith(driveName)) { | ||
docPath = documentPath.slice(driveName.length + 1); | ||
} | ||
const provider = drive.providers.get(`${format}:${type}:${docPath}`); | ||
return provider as IForkProvider | undefined; | ||
} | ||
return; | ||
} | ||
|
||
private _handleEvent(_: Event.IManager, emission: Event.Emission) { | ||
if (emission.schema_id === JUPYTER_COLLABORATION_FORK_EVENTS_URI) { | ||
switch (emission.action) { | ||
case 'create': { | ||
this._forkAddedSignal.emit(emission as any); | ||
break; | ||
} | ||
case 'delete': { | ||
this._forkDeletedSignal.emit(emission as any); | ||
break; | ||
} | ||
default: | ||
break; | ||
} | ||
} | ||
} | ||
|
||
private _disposed = false; | ||
private _drive: ICollaborativeDrive | undefined; | ||
private _eventManager: Event.IManager | undefined; | ||
private _forkAddedSignal = new Signal<ForkManager, IForkChangedEvent>(this); | ||
private _forkDeletedSignal = new Signal<ForkManager, IForkChangedEvent>(this); | ||
} | ||
|
||
export namespace ForkManager { | ||
export interface IOptions { | ||
drive: ICollaborativeDrive; | ||
eventManager: Event.IManager; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.