Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused chat feature #346

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Remove unused chat feature #346

merged 2 commits into from
Sep 9, 2024

Conversation

davidbrochart
Copy link
Collaborator

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

Binder 👈 Launch a Binder on branch jupyterlab/jupyter-collaboration/remove-chat

@davidbrochart
Copy link
Collaborator Author

@brichet could you confirm that this is not needed anymore? IIRC this was for the initial implementation of the chat system, but jupyter-chat uses a different approach.

brichet
brichet reviewed Sep 6, 2024
View reviewed changes
Copy link
Contributor

@brichet brichet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davidbrochart, I've been thinking about doing it for a while. I confirm this is not used for jupyter-chat at least.

packages/docprovider/src/awareness.ts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this expected to keep the IChatMessage interface and messageStreem ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not to my knowledge.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove them if they are not necessary anymore

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you approve this PR?

Copy link
Contributor

@brichet brichet Sep 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was expecting us to remove the remaining IChatMessage and messageStream before, since they are not used anymore.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I didn't get that, thanks!

@davidbrochart davidbrochart merged commit 0754bc7 into main Sep 9, 2024
19 of 20 checks passed
@davidbrochart davidbrochart deleted the remove-chat branch September 9, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brichet brichet brichet approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidbrochart @brichet