Provide the YDrive as the default drive
#365
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jtpio
commented
Sep 25, 2024
Comment on lines
+82
to
+85
| ydrive.translator = (translator ?? nullTranslator).load('jupyterlab'); | ||
| if (globalAwareness) { | ||
| ydrive.globalAwareness = globalAwareness; | ||
| } |
There was a problem hiding this comment.
Because the service manager plugins are activated first and their app is still null during the first phase, we extract setting the translator and globalAwareness to a separate plugin, so it is activated as a regular plugin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #345
Needs jupyterlab/jupyterlab#16794
Register the
YDriveas a the default drive in JupyterLab, relying on the split of the service manager plugins in jupyterlab/jupyterlab#16794.One of the nice side effect is the removal of the
RTC:prefix, which should help fix some issues reported on this repo.rtc-swap-default-drive.webm
ServiceManagerwith plugins jupyterlab#16794@jupyterlab/servicespackage withyalcfor testing