Skip to content

Commit

Permalink
Update configuration on latest 3.x template (#1248)
Browse files Browse the repository at this point in the history
* Update configuration on latest 3.x template

* Fix CI

* More CI fixes

* More CI fixes

* Fix jest configuration

* Fix Jest tests

* TOML does not support interpolation

* Fix installation path

* Lint the code

* Fix test set up

* Remove `prepare` script to fix check releaser

* Add releaser pointing to personal version

* Only generate the version file as `prepare` step
  • Loading branch information
fcollonval authored Jun 19, 2023
1 parent a402291 commit d14ba4a
Show file tree
Hide file tree
Showing 69 changed files with 2,586 additions and 1,504 deletions.
95 changes: 47 additions & 48 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,52 +1,51 @@
module.exports = {
extends: [
'eslint:recommended',
'plugin:@typescript-eslint/eslint-recommended',
'plugin:@typescript-eslint/recommended',
'plugin:prettier/recommended',
'plugin:react/recommended'
],
parser: '@typescript-eslint/parser',
parserOptions: {
project: 'tsconfig.json',
sourceType: 'module'
},
plugins: ['@typescript-eslint'],
rules: {
'@typescript-eslint/explicit-function-return-type': 'off',
"@typescript-eslint/naming-convention": [
"error",
{
"selector": "interface",
"format": ["PascalCase"],
"custom": {
"regex": "^I[A-Z]",
"match": true
}
extends: [
'eslint:recommended',
'plugin:@typescript-eslint/eslint-recommended',
'plugin:@typescript-eslint/recommended',
'plugin:react/recommended'
],
parser: '@typescript-eslint/parser',
parserOptions: {
project: 'tsconfig.test.json',
sourceType: 'module'
},
plugins: ['@typescript-eslint'],
rules: {
'@typescript-eslint/explicit-function-return-type': 'off',
'@typescript-eslint/naming-convention': [
'error',
{
selector: 'interface',
format: ['PascalCase'],
custom: {
regex: '^I[A-Z]',
match: true
}
],
'@typescript-eslint/no-unused-vars': ['warn', { args: 'none' }],
'@typescript-eslint/no-explicit-any': 'off',
'@typescript-eslint/no-namespace': 'off',
'@typescript-eslint/no-this-alias': [
'error',
{
allowedNames: ['self'], // Allow `const self = this`
},
],
'@typescript-eslint/no-use-before-define': 'off',
'@typescript-eslint/quotes': [
'error',
'single',
{ avoidEscape: true, allowTemplateLiterals: false }
],
curly: ['error', 'all'],
eqeqeq: 'error',
'prefer-arrow-callback': 'error'
},
settings: {
react: {
version: 'detect'
}
],
'@typescript-eslint/no-unused-vars': ['warn', { args: 'none' }],
'@typescript-eslint/no-explicit-any': 'off',
'@typescript-eslint/no-namespace': 'off',
'@typescript-eslint/no-this-alias': [
'error',
{
allowedNames: ['self'] // Allow `const self = this`
}
],
'@typescript-eslint/no-use-before-define': 'off',
'@typescript-eslint/quotes': [
'error',
'single',
{ avoidEscape: true, allowTemplateLiterals: false }
],
curly: ['error', 'all'],
eqeqeq: 'error',
'prefer-arrow-callback': 'error'
},
settings: {
react: {
version: 'detect'
}
};
}
};
3 changes: 1 addition & 2 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ about: Create a report to help us improve
title: ''
labels: bug
assignees: ''

---

<!--
Expand Down Expand Up @@ -57,7 +56,7 @@ Paste the output from your browser web console here.
</pre>
</details>

<!--
<!--
To open the browser, please refer to the documentation:
Chrome: https://developers.google.com/web/tools/chrome-devtools/open#console
Firefox: https://developer.mozilla.org/en-US/docs/Tools/Web_Console#Opening_the_Web_Console
Expand Down
5 changes: 4 additions & 1 deletion .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,21 @@ about: Suggest an idea for this project
title: ''
labels: enhancement
assignees: ''

---

<!--Please check the open issue to see if your feature is not already reported.
If this is the case, +1 it to show your interest.-->

## Is your feature request related to a problem? Please describe.

<!--A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]-->

## Describe the solution you'd like

<!--A clear and concise description of what you want to happen.-->

## Describe alternatives you've considered

<!--A clear and concise description of any alternative solutions or features you've considered.-->

## Additional context
Expand Down
29 changes: 0 additions & 29 deletions .github/workflows/binder-on-pr.yaml

This file was deleted.

16 changes: 16 additions & 0 deletions .github/workflows/binder-on-pr.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
name: Binder Badge
on:
pull_request_target:
types: [opened]

jobs:
binder:
runs-on: ubuntu-latest
permissions:
pull-requests: write
steps:
- uses: jupyterlab/maintainer-tools/.github/actions/binder-link@v1
with:

github_token: ${{ secrets.github_token }}

Loading

0 comments on commit d14ba4a

Please sign in to comment.