Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add json5 support for page_config.json #388

Merged
merged 3 commits into from
Mar 22, 2023

Conversation

peytondmurray
Copy link
Contributor

Closes #377.

Following on from this issue, the discussion here, and a discussion from the jupyter_server team meeting, this PR adds json5 support for page_config.json. json5 is only used to load the config if a page_config.json5 is found to avoid incurring a performance overhead for users who just want to use json. An existing test was modified to provide coverage for this.

@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.07 🎉

Comparison is base (1dcca61) 80.86% compared to head (77b2e16) 80.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #388      +/-   ##
==========================================
+ Coverage   80.86%   80.93%   +0.07%     
==========================================
  Files          22       22              
  Lines        1766     1773       +7     
  Branches      332      334       +2     
==========================================
+ Hits         1428     1435       +7     
  Misses        235      235              
  Partials      103      103              
Impacted Files Coverage Δ
jupyterlab_server/config.py 74.57% <100.00%> (+1.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 enabled auto-merge (squash) March 22, 2023 16:41
@blink1073 blink1073 merged commit 48be03a into jupyterlab:main Mar 22, 2023
@welcome
Copy link

welcome bot commented Mar 22, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@peytondmurray peytondmurray deleted the add-json5-page-config branch March 22, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

page_config.json should support json5
3 participants