-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add util to get consolidated page_config from higher levels #448
Add util to get consolidated page_config from higher levels #448
Conversation
Thanks for submitting your first pull request! You are awesome! 🤗 |
for more information, see https://pre-commit.ci
The linter is not happy yet:
|
for more information, see https://pre-commit.ci
I think lint is fixed now. |
jupyterlab_server/config.py
Outdated
if include_higher_levels: | ||
levels = allowed[allowed.index(level) :] | ||
else: | ||
config_dir = SYSTEM_CONFIG_PATH[0] | ||
levels = [level] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still failing here:
jupyterlab_server/config.py:388:5: SIM108 Use ternary operator `levels = allowed[allowed.index(level):] if include_higher_levels else [level]` instead of `if`-`else`-block
Found 1 error.
IMO that's too pedantinc, but linter is a linter.
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thank you @divyansshhh =!
Required for jupyterlab/jupyterlab#16102