-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] Add binder #44
Open
bollwyvl
wants to merge
11
commits into
jupyterlab:master
Choose a base branch
from
bollwyvl:gh-35-add-binder
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[wip] Add binder #44
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
f836530
initial binder setup
bollwyvl 378432b
badge
bollwyvl 45b41a2
start github_anonymous
bollwyvl c888fc0
update binder with github anonymous, jupyterlab
bollwyvl df39800
shotgun more config files
bollwyvl b0df9fd
Update postBuild
bollwyvl 4c702c8
add legacy magic function for notebook
bollwyvl b288195
more legacy
bollwyvl 6a18a7f
github-anonymous is always anonymous
bollwyvl f319a19
rework some test fixtures
bollwyvl 7dde21a
merge upstream
bollwyvl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
name: pull-requests | ||
|
||
channels: | ||
- conda-forge | ||
- nodefaults | ||
|
||
dependencies: | ||
- git | ||
- nodejs >=14,<15 | ||
- jupyterlab >=3,<4 | ||
- python >=3.7,<3.9 | ||
# gitlab | ||
- diff-match-patch | ||
# test | ||
- codecov | ||
- mock >=4.0.0 | ||
- pytest | ||
- pytest-asyncio | ||
- pytest-cov | ||
- pytest-tornasync | ||
# not-yet-on-conda-forge | ||
- pip | ||
# binder demo stuff | ||
- nbgitpuller | ||
- jupyterlab-tour | ||
- pip: | ||
- jupyterlab-git >=0.30.0b3,<0.40.0a0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
{ | ||
"LabApp": { | ||
"tornado_settings": { | ||
"page_config_data": { | ||
"buildCheck": false, | ||
"buildAvailable": false | ||
} | ||
} | ||
}, | ||
"PRConfig": { | ||
"provider": "github-anonymous", | ||
"owner": "jupyterlab", | ||
"repo": "jupyterlab" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
#!/usr/bin/env bash | ||
set -eux | ||
|
||
jlpm --prefer-optional --ignore-offline | ||
jlpm build:lib | ||
jlpm build:labextension:dev | ||
|
||
python -m pip install -e . --ignore-installed --no-deps | ||
|
||
jupyter labextension develop . --overwrite | ||
jupyter server extension enable --py jupyterlab_pullrequests --sys-prefix | ||
jupyter serverextension enable --py jupyterlab_pullrequests --sys-prefix | ||
|
||
jupyter server extension list | ||
jupyter serverextension list | ||
jupyter labextension list | ||
|
||
# copy custom jupyter config out of binder | ||
cp .binder/jupyter_config.example.json ./jupyter_config.json | ||
cp .binder/jupyter_config.example.json ./jupyter_notebook_config.json | ||
cp .binder/jupyter_config.example.json ./jupyter_server_config.json |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -117,3 +117,5 @@ dmypy.json | |
|
||
.DS_Store | ||
coverage/ | ||
|
||
jupyter_config.json |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,10 @@ | ||
from .github_anonymous import AnonymousGithubManager | ||
from .github import GitHubManager | ||
from .gitlab import GitLabManager | ||
|
||
# Supported third-party services | ||
MANAGERS = {"github": GitHubManager, "gitlab": GitLabManager} | ||
MANAGERS = { | ||
"github-anonymous": AnonymousGithubManager, | ||
"github": GitHubManager, | ||
"gitlab": GitLabManager, | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you reset the cache to
None
and not an empty dictionary? The idea to set as an empty dictionary is to allow to use the get method line 298.