Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve config handling #47

Merged
merged 2 commits into from
Apr 20, 2021
Merged

Conversation

fcollonval
Copy link
Member

Improve unit tests

This has been extracted from #44

Improve unit tests
@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@02e2cbd). Click here to learn what that means.
The diff coverage is 93.27%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #47   +/-   ##
=========================================
  Coverage          ?   60.86%           
=========================================
  Files             ?       34           
  Lines             ?     1661           
  Branches          ?       94           
=========================================
  Hits              ?     1011           
  Misses            ?      645           
  Partials          ?        5           
Impacted Files Coverage Δ
jupyterlab_pullrequests/handlers.py 86.60% <64.28%> (ø)
...ab_pullrequests/tests/test_handlers_integration.py 90.62% <83.33%> (ø)
jupyterlab_pullrequests/managers/manager.py 89.21% <85.71%> (ø)
jupyterlab_pullrequests/tests/conftest.py 96.00% <95.83%> (ø)
jupyterlab_pullrequests/managers/github.py 84.61% <100.00%> (ø)
jupyterlab_pullrequests/managers/gitlab.py 80.64% <100.00%> (ø)
jupyterlab_pullrequests/tests/test_github.py 100.00% <100.00%> (ø)
jupyterlab_pullrequests/tests/test_gitlab.py 100.00% <100.00%> (ø)
jupyterlab_pullrequests/tests/test_manager.py 98.36% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02e2cbd...67a0657. Read the comment docs.

@fcollonval fcollonval requested a review from bollwyvl April 19, 2021 07:14
Copy link
Contributor

@bollwyvl bollwyvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fcollonval fcollonval merged commit 7f7f6f2 into jupyterlab:master Apr 20, 2021
@fcollonval fcollonval deleted the ft/improve-tests branch April 20, 2021 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants