Skip to content

Commit

Permalink
Fixing local issue with clang
Browse files Browse the repository at this point in the history
  • Loading branch information
Kirill Kornyakov committed Nov 24, 2013
1 parent ac50876 commit 66a6140
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 9 deletions.
4 changes: 2 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ compiler:
- gcc
- clang
before_script:
- sudo add-apt-repository ppa:ubuntu-toolchain-r/test -y
- sudo apt-get update -qq
- if [ "$CXX" = "g++" ]; then sudo add-apt-repository ppa:ubuntu-toolchain-r/test -y; fi
- if [ "$CXX" = "g++" ]; then sudo apt-get update -qq; fi
- if [ "$CXX" = "g++" ]; then sudo apt-get install -qq g++-4.8; fi
- if [ "$CXX" = "g++" ]; then export CXX="g++-4.8" CC="gcc-4.8"; fi
script: (cd ./code && ./build-and-test.sh)
Expand Down
9 changes: 7 additions & 2 deletions code/3rdparty/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,9 +1,14 @@
# Add Google Test

# The idea is that we silence all warnings here, that's why we
# don't reuse the old value of the CMAKE_CXX_FLAGS variable
if(CXX_MS)
set(CMAKE_CXX_FLAGS "/EHsc")
else()
set(CMAKE_CXX_FLAGS "")
endif()

if((CXX_GCC OR CXX_CLANG) AND (${CMAKE_SYSTEM_NAME} MATCHES "Linux"))
set(Pthread "-pthread")
endif()

add_lib_static(${gtest} "gtest")
target_link_libraries(${gtest} ${Pthread})
3 changes: 0 additions & 3 deletions code/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@ include(../cmake/general.cmake)
# Add Google Test includes and define some variables
add_dir_inc("3rdparty")
set(gtest "gtest")
if(CXX_GCC OR CXX_CLANG)
set(Pthread "-pthread")
endif()

# Include subprojects
add_all_sub_dir("${CMAKE_SOURCE_DIR}")
Expand Down
2 changes: 1 addition & 1 deletion code/kirill-kornyakov-lab4/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ add_app(${appname} "samples")

# Declare unit tests
add_app(${testname} "test")
target_link_libraries(${testname} ${gtest} ${Pthread})
target_link_libraries(${testname} ${gtest})

#############################################
##### Testing
Expand Down
2 changes: 1 addition & 1 deletion code/kirill-kornyakov-lab4/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@
- `include` содержит публичные заголовочные файлы, предназначенные для
включения в пользовательские проекты.
- `samples` содержит примеры использования класса в пользовательских
приложениях.
приложениях (в виде консольных утилит).
- `src` содержит реализацию класса.
- `test` содержит модульные тесты для вашего класса.

0 comments on commit 66a6140

Please sign in to comment.