-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(routing): Added logs for routing #3097
Open
Sarthak1799
wants to merge
5
commits into
main
Choose a base branch
from
logs-in-routing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sarthak1799
added
C-feature
Category: Feature request or enhancement
A-routing
Area: Routing
labels
Dec 9, 2023
Can you attach screenshots as to how the log lines would be printed? |
vspecky
requested changes
Jan 3, 2024
vspecky
previously approved these changes
Jan 18, 2024
prajjwalkumar17
previously approved these changes
Jan 19, 2024
@tinu-hareesswar can we identify the key events and send the stream to the kafka topic so that we can have these reflections in Clickhouse as well? |
Sarthak1799
dismissed stale reviews from prajjwalkumar17 and vspecky
via
February 1, 2024 10:02
9475e7d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Added logs in routing flows for better metrics and logging using dashboard.
Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --all
cargo clippy