fix(frm): update FRM manual review flow #3176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to reject the txn
jagan-jaya
previously approved these changes
Dec 22, 2023
There was a problem hiding this comment.
@kashif-m
I'm good with the changes, we need to have someone from core to check payment_response.rs file just to mitigate unknown issues. I understand that the status is changed only for FRM case but payment_response is currently used in every payment call so just need more eyes to verify.
vspecky
previously approved these changes
Dec 22, 2023
There was a problem hiding this comment.
Should probably rename the file as well. Can be taken up later.
Comment on lines
+523
to
+529
| ( | ||
| enums::AttemptStatus::Authorized, | ||
| enums::AttemptStatus::Unresolved, | ||
| Some(frm_message), | ||
| ) => match frm_message.frm_status { | ||
| enums::FraudCheckStatus::Fraud | enums::FraudCheckStatus::ManualReview => { | ||
| attempt_status |
There was a problem hiding this comment.
Nit:
Suggested change
| ( | |
| enums::AttemptStatus::Authorized, | |
| enums::AttemptStatus::Unresolved, | |
| Some(frm_message), | |
| ) => match frm_message.frm_status { | |
| enums::FraudCheckStatus::Fraud | enums::FraudCheckStatus::ManualReview => { | |
| attempt_status | |
| ( | |
| enums::AttemptStatus::Authorized, | |
| enums::AttemptStatus::Unresolved, | |
| Some(FrmMessage { frm_status: enums::FraudCheckStatus::Fraud | enums::FraudCheckStatus::ManualReview }), | |
| ) => attempt_status, |
Narayanbhat166
previously approved these changes
Jan 5, 2024
kashif-m
dismissed stale reviews from Narayanbhat166, vspecky, and jagan-jaya
via
acb2fec
vspecky
previously approved these changes
Jan 9, 2024
jagan-jaya
approved these changes
Jan 16, 2024
vspecky
approved these changes
Jan 16, 2024
Narayanbhat166
approved these changes
Jan 16, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
2 tasks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
kashif-m
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
#3175
Additional Changes
Motivation and Context
How did you test it?
Tested locally using postman collection
https://galactic-capsule-229427.postman.co/workspace/My-Workspace~2b563e0d-bad3-420f-8c0b-0fd5b278a4fe/collection/9906252-e8ad195c-90f5-4527-a40b-1a25bc9bedd2?action=share&creator=9906252
Test Cases
Checklist
cargo +nightly fmt --allcargo clippy